mark TransactionFut as Send #723

georgewhewell · 2021-12-21T19:55:17Z

Motivation

transactions_unordered() is not Send

Solution

mark TransactionFut as Send

PR Checklist

Added Tests
Added Documentation
Updated the changelog

mattsse

lg, but this won't work in wasm.
here's an existing workaround for that

ethers-rs/ethers-middleware/src/gas_escalator/mod.rs

Lines 19 to 22 in dcf2002

    
           #[cfg(target_arch = "wasm32")] 
        
           type WatcherFuture<'a> = Pin<Box<dyn futures_util::stream::Stream<Item = ()> + 'a>>; 
        
           #[cfg(not(target_arch = "wasm32"))] 
        
           type WatcherFuture<'a> = Pin<Box<dyn futures_util::stream::Stream<Item = ()> + Send + 'a>>;

gakonst

great! if you're building on ethers and not already in the chatroom / want to talk more about what you're doing: https://t.me/ethers_rs

mark TransactionFut as Send

1da472c

mattsse suggested changes Dec 21, 2021

View reviewed changes

no send when wasm32

ff4ea9f

gakonst approved these changes Dec 22, 2021

View reviewed changes

gakonst merged commit bb0cd7a into gakonst:master Dec 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mark TransactionFut as Send #723

mark TransactionFut as Send #723

georgewhewell commented Dec 21, 2021

mattsse left a comment

gakonst left a comment •

edited

Loading

	#[cfg(target_arch = "wasm32")]
	type WatcherFuture<'a> = Pin<Box<dyn futures_util::stream::Stream<Item = ()> + 'a>>;
	#[cfg(not(target_arch = "wasm32"))]
	type WatcherFuture<'a> = Pin<Box<dyn futures_util::stream::Stream<Item = ()> + Send + 'a>>;

mark TransactionFut as Send #723

mark TransactionFut as Send #723

Conversation

georgewhewell commented Dec 21, 2021

Motivation

Solution

PR Checklist

mattsse left a comment

Choose a reason for hiding this comment

gakonst left a comment • edited Loading

Choose a reason for hiding this comment

gakonst left a comment •

edited

Loading